Bug [✓]: Analysis Report, Analysis and Key Moments game board popup perspective wrong

Sort:
jas0501

The board popup is now always presenting from White's perspective. It should be presenting from the game board's perspective.

Analysis:

Key Moments:

In the past it did present from the popup board from the correct perspective. I had to dig to find a picture, from the past, showing the board from Black's perspective:


The Fix:
Board popups should always reflect the current game board's perspective.

Note: This goes for replay of the opponent's key moments when the board flips.

 

mugesu

thankshappy.png

jas0501

Still an issue:


I just want to confirm that the analysis board popup change issue was a mistake and has been ticketed.

Typically a change to working code might indicate a feature change. In this case the change is a mistake.

So has it been ticketed?

How to reproduce:
1. visit https://www.chess.com/analysis/game/live/14461072325
2. Position pointer on black's  1... c3 move:


jas0501

Still wondering, has this issue been ticketed?

Martin_Stahl

Did you report it? If so, it's probably ticketed

jas0501
Martin_Stahl wrote:

Did you report it? If so, it's probably ticketed

I'm looking for a more definitive answer. When working code is changed/broken it is easier and quicker to reverse the change while the change is still fresh in the mind of the coder. The longer it takes to get to it the longer it takes to reload the code context and fix the issue.

 This assumes the code change is classified as a bug. Somehow the working code that presented the popup from the perspective of the game board got changed to always present from white's perspective.. The could have been intentional, i.e. a new "feature". It has been almost 2 weeks since it was reported. I just want to hear that it is in fact a bug and has been ticketed.

 

Martin_Stahl

Found out it had been ticketed. If I hear more on the status, I'll update.

jas0501

1/2 fixed. Analysis tab now presents popup from board's perspective:

However key moments still is a problem:


jas0501

Correction. 1/3 fixed. The max analysis line also presents the wrong perspective:
Show lines is correct:


Max analysis is incorrect:


jas0501

Max Analysis and Key Moments still present only White's perspective of the game.

Still an issue.

jas0501

Still an issue:


jas0501

Still an issue with Max Analysis and Key Moments.

It has been 2 months since the working code was broken. This type of bug is EASY to fix as the code exists somewhere in to code tree . It is shameful the this type of introduce bug that breaks existing functionality is not given the highest priority. It should be for 3 reasons:
1. Exiting capabilities should not be lost!
2. It is easy to fix, just by looking the the old code
3. Fixing it immediately is the easiest and best time to fix it as the code context in fresh in the mind of the programmer that introduce the bug.

Why is this still an issue?

jas0501

Still an issue for Max Analysis. The Key moments issue has been eliminated with the new Game Review release. Here is a Max Analysis animated GIF showing the board presented from the wrong perspective.

jas0501

Still an issue.

jas0501

Still broken.

It has been over 90 days since the feature was broken.

jas0501

Fixed ✓.