Bug ✓: Analysis Report -- Details - no fields should be editable, all are

Sort:
jas0501

The fields on the detail tab should not be editable. I can edit and save the changes to all fields. White actually lost, the game was not played in the future 6/28/19, My rating is not 2556, not my opponent's 3550

chadnilsen

Hmm...what's wrong with that though?

jdcannon

I suppose I do have to ask the same question. What is the harm? I'm not opposed to making them uneditable but unless there is some harm, I am not sure why we would. 

jas0501
jdcannon wrote:

I suppose I do have to ask the same question. What is the harm? I'm not opposed to making them uneditable but unless there is some harm, I am not sure why we would. 

It is called data integrity. Anyone can change the fields corrupting the information.

As it stands anyone can analyze or view the analysis of  any game, mine,, yours, master games and change the information, corrupting the individual game information as presented in the analysis report details.

 

jdcannon

I see the data persists. That does seems like an issue. 

jas0501
jdcannon wrote:

I see the data persists. That does seems like an issue. 

Yup!

ChristianBC

I vote this to be bug (hack?) of the year!

jdcannon

So the thing here is that if you change that data, only you will see the change. Anyone else looking at your game history and analysis will see the correct original information. 

jas0501
jdcannon wrote:

So the thing here is that if you change that data, only you will see the change. Anyone else looking at your game history and analysis will see the correct original information. 

Even still the fields should not be editable.


Your point does raise an interesting question I wondered about, the saved version. If I do analysis and add comments and save on my game or someone else's game that saved version is associated to me only.

I'd like to test that. I picked a random master game and added comments and saved it. Here is a screen shot of the commented Analysis view

 

Does anyone else see these comments when accessing (warning access this could use up your game analysis quota) https://www.chess.com/analysis/game/master/14287367?

jdcannon

On you see those comments. 

ChristianBC

I see that kowalsky played black and there was no comments. 

jas0501
ChristianBC wrote:

I see that kowalsky played black and there was no comments. 

Thanks for the confirmation that saves are unique to the user,

jas0501

Fixed. Fields on the Details tab are no longer editable.