I'm for studying mainlines, it gives more adequate understanding of the chess. 😎
What are the factors to consider while building and opening repertoire?
#1
"For intermediate players, what is the most optimal way of choosing a rep?"
There are priorities:
1) A defence for black against 1 e4
2) A defence for black against 1 d4
3) An opening for white.
It is an advantage if 1) and 2) are similar: you gain more experience with similar positions.
For the same reason it is an advantage if 3) is a reverse system of 1) or 2).
"1. According to IM Irina Bulmaga on her master method, below 2300 FIDE should play sidelines in order to have time to study other areas like endgames etc."
++ Yes, fully agree. Even below 2500 study of openings makes no sense.
"2. According to IM Andras Toth on his YouTube channel he champions playing mainlines even for beginners." ++ Playing maybe yes, but studying no way. Study and upkeep of main lines is a full time job. For a professional grandmaster that is worthwhile, they earn their living from it and they already know enough about endgames and tactics.
"So am confused; a certain 1900 Fide (2100 highest) player once told me they started playing the French defence with black cos they loved Vickor Korchnoi, as an intermediate player who loves Michael Tal does it make sense to play Nardorf and the KID as black and Ruy Lopez as white?" ++ Maybe, but you will have a difficult learning path with many losses.
A slightly simpler path would be either:
1) Najdorf as black, 2) Benoni as black, 3) English as white
1) Pirc as black, 2) King's Indian Defence as black, 3) King's Indian Attack as white
1) Ruy Lopez as black, Queen's Gambit as black, Ruy Lopez as white
The last one is the preferred one.
<1. According to Irina Bulmaga I her master method, below 2300 FIDE should play sidelines in order to have time to study other areas like endgames etc.
2. According to IM Andras Toth on his YouTube channel he champions playing mainlines even for beginners.>
You should play lines you understand and feel comfortable with, starting with mainlines. Now, playing mainlines doesn't mean playing the Mar Del Plata against the King's Indian and the Poisoned Pawn against Najdorf. In deeply explored openings there are perhaps half a dozen systems that could be considered mainlines.
If that doesn't work, switch to the respectable sidelines. The worst approach is to start with crappy sidelines where the play looks nothing like the other lines.
After some time you have to reassess the whole repertoire. Try new things, avoid boredom, change a line you don't like as much as before, get a reserve line for different situations, and so on.
<they started playing the French defence with black cos they loved Vickor Korchnoi, as an intermediate player who loves Michael Tal does it make sense to play Nardorf and the KID as black and Ruy Lopez as white?>
No. Korchnoi was a big researcher in openings, Tal's play was never about openings and he played a bit of everything anyway. Copying his play may not be best either (eg for a very long time he avoided playing d4-d5 closing the center in the Closed Spanish, hoping Black would play exd4 at some point so he would get an immediate tactical battle; but under the influence of engines, d5 is now pretty much automatic).

Find something solid that suits your style. Also, you want to find something that is fun to play and gives you a lot of chances
For 1.e4, I like the French as I always have a plan. The Nc3 and Nd2 lines need a little work but hardly anyone plays them below 1700s at least.
For 1.d4, The Semi-Slav is a more theoretical opening but no one really plays into the mainlines because they like to play sidelines. It is solid and will give you an idea of what to do against variation sidelines like the Reti. However, I do play a sideline with the Winawer Countergambit because people are playing too much exchange Slav.
For intermediate players, what is the most optimal way of choosing a rep?
1. According to IM Irina Bulmaga on her master method, below 2300 FIDE should play sidelines in order to have time to study other areas like endgames etc.
2. According to IM Andras Toth on his YouTube channel he champions playing mainlines even for beginners.
So am confused; a certain 1900 Fide (2100 highest) player once told me they started playing the French defence with black cos they loved Vickor Korchnoi, as an intermediate player who loves Michael Tal does it make sense to play Nardorf and the KID as black and Ruy Lopez as white? , my current repertoire is based on 1. e4 Keep it simple by Sielecki and was thinking of getting the on KIS by black, what you-all think?